Re: [Qemu-devel] [PATCH v2 2/8] x86_iommu: move vtd_generate_msi_message in common file

[Eduardo Habkost]

On Fri, Sep 14, 2018 at 01:26:57PM -0500, Brijesh Singh wrote:
> The vtd_generate_msi_message() in intel-iommu is used to construct a MSI
> Message from IRQ. A similar function will be needed when we add interrupt
> remapping support in amd-iommu. Moving the function in common file to
> avoid the code duplication. Rename it to x86_iommu_irq_to_msi_message().
> There is no logic changes in the code flow.
> 
> Signed-off-by: Brijesh Singh <address@hidden>
> Suggested-by: Peter Xu <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Tom Lendacky <address@hidden>
> Cc: Suravee Suthikulpanit <address@hidden>

Generic code match the original struct/function exactly.

Reviewed-by: Eduardo Habkost <address@hidden>

-- 
Eduardo