[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/9] s390x/tcg: fix FP register pair checks
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/9] s390x/tcg: fix FP register pair checks |
Date: |
Mon, 17 Sep 2018 11:12:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Am 30.08.18 um 21:55 schrieb Richard Henderson:
> On 08/30/2018 05:27 AM, David Hildenbrand wrote:
>> Valid register pairs are 0/2, 1/3, 4/6, 5/7, 8/10, 9/11, 12/14, 13/15.
>>
>> R1/R2 always selects the lower number, so the current checks are not
>> correct as e.g. 2/4 could be selected as a pair.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> target/s390x/translate.c | 24 ++++++++++++------------
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
>> index 1ca6ef45a1..5cc65b0840 100644
>> --- a/target/s390x/translate.c
>> +++ b/target/s390x/translate.c
>> @@ -1110,7 +1110,7 @@ typedef struct {
>> #define IF_HFP3 0x0004 /* r3 points at fp reg for HFP instructions
>> */
>> #define IF_BFP 0x0008 /* binary floating point instruction */
>> #define IF_DFP 0x0010 /* decimal floating point instruction */
>> -#define IF_PRIV 0x0020 /* priviledged instruction */
>> +#define IF_PRIV 0x0020 /* privileged instruction */
>> @@ -6013,7 +6019,7 @@ static DisasJumpType translate_one(CPUS390XState *env,
>> DisasContext *s)
>>
>> /* process flags */
>> if (insn->flags) {
>> - /* priviledged instruction */
>> + /* privileged instruction */
>
> Merge these back into the previous patch. But otherwise,
>
Whops, sure will do. Thanks!
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
--
Thanks,
David / dhildenb
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 8/9] s390x/tcg: fix FP register pair checks,
David Hildenbrand <=