Re: [Qemu-devel] [PATCH v2] usb: assign unique serial numbers to hid devices

[Dr. David Alan Gilbert]

* Gerd Hoffmann (address@hidden) wrote:
> > > And even if it turns out autosuspend is still an issue:  I think
> > > meanwhile we can really stop worrying about guests running in old qemu
> > > versions with broken usb suspend (fixed in 0.13 !).  If needed we can
> > > enable autosuspend unconditionally in guests.
> > 
> > OK, so what about the other question - which serial number do we end up
> > with after this patch; do we get the 89126/28754/68284 or do we get the
> > path based one from your change that calls usb_desc_create_serial?
> 
> The path based one. and the numbers are the first part, i.e. this:
> 
> address@hidden ~# lsusb -vs1:2
> [ ... ]
>   iManufacturer           1 QEMU
>   iProduct                3 QEMU USB Tablet
>   iSerial                 6 28754-0000:00:02.1:00.0-1
>   bNumConfigurations      1
> [ ... ]

Ah OK, that's fine; so :


Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> cheers,
>   Gerd
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK