[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/35] exec: use cpu_reset_interrupt
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 06/35] exec: use cpu_reset_interrupt |
Date: |
Tue, 18 Sep 2018 13:49:09 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/17/18 9:30 AM, Emilio G. Cota wrote:
> From: Paolo Bonzini <address@hidden>
>
> It will be changed to an atomic operation soon.
>
> Cc: Peter Crosthwaite <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> accel/tcg/cpu-exec.c | 6 +++---
Reviewed-by: Richard Henderson <address@hidden>
> diff --git a/exec.c b/exec.c
> index 6826c8337d..0b8e2420cf 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -776,7 +776,7 @@ static int cpu_common_post_load(void *opaque, int
> version_id)
>
> /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the
> version_id is increased. */
> - cpu->interrupt_request &= ~0x01;
> + cpu_reset_interrupt(cpu, 0x01);
I guess this doesn't hurt, although it's irrelevant.
We're in the middle of loadvm and there will not be
concurrent modification.
r~
- Re: [Qemu-devel] [PATCH 03/35] target/openrisc: use cpu_reset_interrupt, (continued)
- [Qemu-devel] [PATCH 09/35] target/cris: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 07/35] target/alpha: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 04/35] target/ppc: use cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 06/35] exec: use cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 11/35] target/i386: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 10/35] target/hppa: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 08/35] target/arm: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 02/35] target/i386: use cpu_reset_interrupt, Emilio G. Cota, 2018/09/17