[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 7/7] qemu_thread_create: propagate the er
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 7/7] qemu_thread_create: propagate the error to callers to handle |
Date: |
Thu, 20 Sep 2018 15:32:59 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, 09/19 23:51, Fam Zheng wrote:
> > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> > index d7a4bbd91f..e7cbb0c368 100644
> > --- a/hw/rdma/rdma_backend.c
> > +++ b/hw/rdma/rdma_backend.c
> > @@ -165,7 +165,8 @@ static void start_comp_thread(RdmaBackendDev
> > *backend_dev)
> > ibv_get_device_name(backend_dev->ib_dev));
> > backend_dev->comp_thread.run = true;
> > qemu_thread_create(&backend_dev->comp_thread.thread, thread_name,
> > - comp_handler_thread, backend_dev,
> > QEMU_THREAD_DETACHED);
> > + comp_handler_thread, backend_dev,
> > + QEMU_THREAD_DETACHED, &error_abort);
>
> Previously we don't abort() QEMU if a new thread cannot be created. I think we
> want some more robustness here. Peter?
Looking more closely, this is not migration code, but device code. So it doesn't
hurt as much, but still, in the longer term we may want to handle the error
instead of abort(). E.g. in activate_device() set an error state. A task for a
separate series, though. So this patch can be kept as is, or add a FIXME
comment.
Fam
- Re: [Qemu-devel] [PATCH RFC v3 4/7] migration: fix the compression code, (continued)
[Qemu-devel] [PATCH RFC v3 3/7] qemu_init_vcpu: add a new Error parameter to propagate, Fei Li, 2018/09/19
[Qemu-devel] [PATCH RFC v3 5/7] migration: fix the multifd code, Fei Li, 2018/09/19
[Qemu-devel] [PATCH RFC v3 6/7] qemu_thread_join: fix segmentation fault, Fei Li, 2018/09/19
[Qemu-devel] [PATCH RFC v3 7/7] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2018/09/19
Re: [Qemu-devel] [PATCH RFC v3 0/7] qemu_thread_create: propagate errors to callers to check, Fam Zheng, 2018/09/19
Re: [Qemu-devel] [PATCH RFC v3 0/7] qemu_thread_create: propagate errors to callers to check, Peter Xu, 2018/09/19