[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 21/52] hw/timer/cmsdk-apb-dualtimer: Implement CM
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL 21/52] hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module |
|
Date: |
Mon, 24 Sep 2018 13:34:35 +0100 |
On 9 September 2018 at 21:34, Paolo Bonzini <address@hidden> wrote:
> On 24/08/2018 11:33, Peter Maydell wrote:
>> ze);
>> +
>> + if (offset >= A_TIMERITCR) {
>> + switch (offset) {
>> + case A_TIMERITCR:
>> + s->timeritcr = value & R_TIMERITCR_VALID_MASK;
>> + cmsdk_apb_dualtimer_update(s);
>> + case A_TIMERITOP:
>> + s->timeritop = value & R_TIMERITOP_VALID_MASK;
>> + cmsdk_apb_dualtimer_update(s);
>> + default:
>
> Two missing "break"s here (Coverity CID 1395626 and 1395633).
Whoops. Patch sent.
thanks
-- PMM