Re: [Qemu-devel] [PATCH 2/3] Linux user mode usbfs types and defs.

[Laurent Vivier]

Le 19/09/2018 à 10:04, Cortland Tölva a écrit :
> Provide ioctl definitions for the generic thunk mechanism to
> convert most usbfs calls.
> 
> Signed-off-by: Cortland Tölva <address@hidden>
> ---
>  linux-user/ioctls.h        | 38 ++++++++++++++++++++++++++
>  linux-user/syscall.c       |  3 ++
>  linux-user/syscall_defs.h  | 32 ++++++++++++++++++++++
>  linux-user/syscall_types.h | 68 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 141 insertions(+)
> 
...
> diff --git a/linux-user/syscall_types.h b/linux-user/syscall_types.h
> index 24631b09be..b98a23b0f1 100644
> --- a/linux-user/syscall_types.h
> +++ b/linux-user/syscall_types.h
...
> +STRUCT(usbdevfs_urb,
> +        TYPE_CHAR, /* type */
> +        TYPE_CHAR, /* endpoint */
> +        TYPE_INT, /* status */
> +        TYPE_INT, /* flags */
> +        TYPE_PTRVOID, /* buffer */
> +        TYPE_INT, /* buffer_length */
> +        TYPE_INT, /* actual_length */
> +        TYPE_INT, /* start_frame */
> +        TYPE_INT, /* union number_of_packets stream_id */
> +        TYPE_INT, /* error_count */
> +        TYPE_INT, /* signr */
> +        TYPE_PTRVOID, /* usercontext */
> +        MK_ARRAY(MK_STRUCT(STRUCT_usbdevfs_iso_packet_desc), 0)) /* desc */

As this can't work as-is and is managed in following patch, could you
move usbdevfs_urb and related definitions to the patch that uses them?

The other parts of the patch seem good.

Thanks,
Laurent