Re: [Qemu-devel] [PATCH 1/2] hw/arm/smmu-common: Fix the name of the iommu memory regions

[Peter Maydell]

On 21 September 2018 at 08:01, Eric Auger <address@hidden> wrote:
> At the point smmu_find_add_as() gets called, the bus number might
> not be computed. Let's change the name of IOMMU memory region and
> just use the devfn and an incrementing index.
>
> The name only is used for debug.
>
> Signed-off-by: Eric Auger <address@hidden>
> ---
>  hw/arm/smmu-common.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index 55c75d65d2..3f55cfd193 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -311,6 +311,7 @@ static AddressSpace *smmu_find_add_as(PCIBus *bus, void 
> *opaque, int devfn)
>      SMMUState *s = opaque;
>      SMMUPciBus *sbus = g_hash_table_lookup(s->smmu_pcibus_by_busptr, bus);
>      SMMUDevice *sdev;
> +    static uint index;

"uint" isn't a standard type (and causes a build failure on
at least one of my build systems). Did you mean "unsigned int" ?

thanks
-- PMM