Re: [Qemu-devel] [PULL 0/6] Usb 20180917 patches

[Gerd Hoffmann]

On Tue, Sep 25, 2018 at 11:05:29AM +0100, Peter Maydell wrote:
> On 17 September 2018 at 10:56, Gerd Hoffmann <address@hidden> wrote:
> > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
> >
> >   Merge remote-tracking branch 
> > 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 
> > 16:44:20 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kraxel.org/qemu tags/usb-20180917-pull-request
> >
> > for you to fetch changes up to 5ef919130963ba478a65b1e559c71b876025cff7:
> >
> >   usb: assign unique serial numbers to hid devices (2018-09-17 11:54:26 
> > +0200)
> >
> > ----------------------------------------------------------------
> > usb: bugfixes for mtp, hub and hid devices.
> >
> 
> Hi. This seems to fail 'make check' on x86-64 Linux host:
> 
> TEST: tests/qom-test... (pid=27321)
>   /sh4/qom/none:                                                       OK
>   /sh4/qom/shix:                                                       OK
>   /sh4/qom/r2d:
> Unexpected error in u
> sb_try_create_simple() at
> /home/petmay01/linaro/qemu-for-merges/hw/usb/bus.c:338:
> qemu-system-sh4: Failed to create USB device 'usb-kbd'
> Broken pipe
> /home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:129:
> kill_qemu() detected QEMU death
> from signal 6 (Aborted) (core dumped)
> FAIL
> GTester: last random seed: R02S8e2f5918ab744c8a831cb30dc22eb415
> (pid=27435)
> FAIL: tests/qom-test
> TEST: tests/test-hmp... (pid=27445)

Hmm.  /me looks surprised.  Works fine for me, both the original pull
tag and the queue rebased to latest master.

Can you figure which patch causes this?  I'd guess the serial number
patch, even though I can't see yet how that one crashes qemu.

There is also the patch adding separate config options foe hub and hid
devices, which might cause usb-kbd not being compiled in, but qemu
should not dump core due to this ...

thanks,
  Gerd