Re: [Qemu-devel] [PATCH v3 0/5] dirty-bitmaps: fix QMP command permissions

[Vladimir Sementsov-Ogievskiy]

26.09.2018 02:49, John Snow wrote:
> based on: jsnow/bitmaps staging branch
>
> This series builds on a previous standalone patch and adjusts
> the permission for all (or most) of the QMP bitmap commands.
>
> John Snow (5):
>    block/dirty-bitmaps: add user_modifiable status checker
>    block/dirty-bitmaps: fix merge permissions
>    block/dirty-bitmaps: allow clear on disabled bitmaps
>    block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps
>    block/backup: prohibit backup from using in-use bitmaps
>
>   block/dirty-bitmap.c         | 13 +++++---
>   blockdev.c                   | 75 ++++++++++++++++++++------------------------
>   include/block/dirty-bitmap.h |  1 +
>   3 files changed, 44 insertions(+), 45 deletions(-)

Great! Thank you for clearing this. I contributed a lot to this mess 
with my qmp-locked(

PS: I have a draft patch in my current developments to allow set/reset 
bits in disabled bitmaps, which is needed to use BdrvDirtyBitmap as a 
shared named copy-bitmap between fleecing-hook filter and backup job. So 
"disabled" is actually only for use in bdrv_set_dirty(), to disable 
automatic bitmap updates on guest writes.

--
Best regards,
Vladimir