Re: [Qemu-devel] [PATCH] tests: Restore check-qdict unit test

[Thomas Huth]

On 2018-09-26 14:23, Markus Armbruster wrote:
> Commit 0bcc8e5bd8d accidentally dropped check-qdict from the list of
> unit tests (again, see commit 4429532b48a).  Put it back, and fix up
> the test.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/Makefile.include | 2 +-
>  tests/check-qdict.c    | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 87c81d1dcc..f71fef9d88 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -40,7 +40,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>  
>  check-unit-y = tests/check-qdict$(EXESUF)
>  gcov-files-check-qdict-y = qobject/qdict.c
> -check-unit-y = tests/check-block-qdict$(EXESUF)
> +check-unit-y += tests/check-block-qdict$(EXESUF)
>  gcov-files-check-block-qdict-y = qobject/block-qdict.c
>  check-unit-y += tests/test-char$(EXESUF)
>  gcov-files-check-qdict-y = chardev/char.c
> diff --git a/tests/check-qdict.c b/tests/check-qdict.c
> index 86e9fe7dc4..a1e8305066 100644
> --- a/tests/check-qdict.c
> +++ b/tests/check-qdict.c
> @@ -12,6 +12,8 @@
>  
>  #include "qemu/osdep.h"
>  #include "qapi/qmp/qdict.h"
> +#include "qapi/qmp/qnum.h"
> +#include "qapi/qmp/qstring.h"
>  
>  /*
>   * Public Interface test-cases
> 

Reviewed-by: Thomas Huth <address@hidden>