[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification |
Date: |
Tue, 2 Oct 2018 23:04:36 +0400 |
Hi
On Thu, Aug 30, 2018 at 6:03 PM Markus Armbruster <address@hidden> wrote:
>
> Marc-André Lureau <address@hidden> writes:
>
> > Simplify the code around qmp_dispatch():
> > - rely on qmp_dispatch/check_obj() for message checking
> > - have a single send_response() point
> > - constify send_response() argument
> >
> > It changes a couple of error messages:
> >
> > * When @req isn't a dictionary, from
> > Invalid JSON syntax
> > to
> > QMP input must be a JSON object
> >
> > * When @req lacks member "execute", from
> > this feature or command is not currently supported
> > to
> > QMP input lacks member 'execute'
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > Reviewed-by: Michael Roth <address@hidden>
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
Can someone take the patch? thanks
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification,
Marc-André Lureau <=