Re: [Qemu-devel] [PATCH 2/2] nbd/server: drop old-style negotiation

[Eric Blake]

On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> After the previous commit, nbd_client_new first parameter is always
> NULL. Let's drop it with all corresponding old-style negotiation code
> path which is unreachable now.

Being able to force oldstyle negotiation for interoperability testing 
may still be useful. But as fewer and fewer interesting clients exist 
that want oldstyle (after all, extensions are only usable with 
newstyle), I'm finding it hard to justify that we need qemu to be the 
oldstyle server for such interoperability testing (and I can always keep 
an older qemu binary around).

> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   include/block/nbd.h |  3 +--
>   blockdev-nbd.c      |  2 +-
>   nbd/server.c        | 53 +++++++++++++--------------------------------
>   qemu-nbd.c          |  2 +-
>   4 files changed, 18 insertions(+), 42 deletions(-)

> +++ b/blockdev-nbd.c
> @@ -36,7 +36,7 @@ static void nbd_accept(QIONetListener *listener, 
> QIOChannelSocket *cioc,
>                          gpointer opaque)
>   {
>       qio_channel_set_name(QIO_CHANNEL(cioc), "nbd-server");
> -    nbd_client_new(NULL, cioc,
> +    nbd_client_new(cioc,
>                      nbd_server->tlscreds, NULL,

Could rewrap into fewer lines, but that's cosmetic.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org