Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

[Vladimir Sementsov-Ogievskiy]

03.10.2018 20:32, Eric Blake wrote:
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
It's unexpected behavior that without -x option qemu-nbd do old-style
negotiation. Let's use "" as a default name instead (as it is already
done if tls is used) and therefore, drop old-style negotiation from
Qemu NBD server.

Oddly enough, I wrote a similar patch in parallel, and am only now just seeing 
your mail. Yours is a bit stronger than mine (I added 'qemu-nbd -O' to allow 
explicit fallback to oldstyle, while you ripped it out altogether).  The client 
can negotiate either style, so we don't need an option on the client side; 
rather, this is all about what the server should do by default.

https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00568.html

Does anyone have a preference between the two? Here's the last time it was 
discussed:

https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03252.html

Hm, I think everyone who like new-style should answer that he don't care 
(except stricter way is a bit better: don't have options and code which we 
don't need).
But if there is someone who has client which support only old-style negotiation 
his unhappiness (in case of strict way) will outweigh all our "bits":)

I'm from the first group). But let's chose your patch



Vladimir Sementsov-Ogievskiy (2):
   qemu-nbd: drop old-style negotiation
   nbd/server: drop old-style negotiation

  include/block/nbd.h |  3 +--
  blockdev-nbd.c      |  2 +-
  nbd/server.c        | 53 +++++++++++++--------------------------------
  qemu-nbd.c          | 25 +++++----------------
  4 files changed, 23 insertions(+), 60 deletions(-)





--
Best regards,
Vladimir