Re: [Qemu-devel] [PATCH v3 0/4] softfloat: Fix division

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> Changes from v2:
>   * Add shift128Left.  I had been using shortShift128Left,
>     with a shift of 64, which lead to undefined behaviour.
>     Which I suspect is exactly the Heisenbug Alex saw.

No weirdness this time around

>
>     I did keep the R-b tags I had already applied.

You already have mine but this version also:

Tested-by: Alex Bennée <address@hidden>

>
>
> r~
>
>
> Richard Henderson (4):
>   softfloat: Fix division
>   softfloat: Specialize udiv_qrnnd for x86_64
>   softfloat: Specialize udiv_qrnnd for s390x
>   softfloat: Specialize udiv_qrnnd for ppc64
>
>  include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----
>  fpu/softfloat.c                | 35 ++++++++++++++-----
>  2 files changed, 80 insertions(+), 17 deletions(-)


--
Alex Bennée