[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/11] build: rename CONFIG_QGA_NTDDDISK to C
From: |
Sameeh Jubran |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/11] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI |
Date: |
Sun, 7 Oct 2018 12:29:49 +0300 |
Reviewed-by: Sameeh Jubran <address@hidden>
On Thu, Oct 4, 2018 at 4:23 PM Marc-André Lureau
<address@hidden> wrote:
>
> Hi
>
> On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský <address@hidden> wrote:
> >
> > There was inconsistency between commits:
> >
> > 50cbebb9a3 configure: add configure check for ntdddisk.h
> > a3ef3b2272 qga: added bus type and disk location path
> >
> > The first commit added #define CONFIG_QGA_NTDDDISK but the second commit
> > expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in
> > second patch was never used.
> >
> > Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header
> > file that is being checked for.
> >
> > Signed-off-by: Tomáš Golembiovský <address@hidden>
>
> Reviewed-by: Marc-André Lureau <address@hidden>
>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 58862d2ae8..0f168607e8 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6201,7 +6201,7 @@ if test "$mingw32" = "yes" ; then
> > echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak
> > fi
> > if test "$guest_agent_ntddscsi" = "yes" ; then
> > - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak
> > + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak
> > fi
> > if test "$guest_agent_msi" = "yes"; then
> > echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak
> > --
> > 2.19.0
> >
>
--
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.
- Re: [Qemu-devel] [PATCH v4 04/11] qga-win: add debugging information, (continued)
- [Qemu-devel] [PATCH v4 10/11] qga: return disk device in guest-get-fsinfo, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 01/11] qga-win: fix crashes when PCI info cannot be retrived, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 03/11] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 08/11] qga-win: refactor disk info, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 06/11] configure: add test for libudev, Tomáš Golembiovský, 2018/10/04
- [Qemu-devel] [PATCH v4 09/11] qga-win: handle multi-disk volumes, Tomáš Golembiovský, 2018/10/04