[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/6] target/unicore32: remove tlb_flush from
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/6] target/unicore32: remove tlb_flush from uc32_init_fn |
Date: |
Tue, 09 Oct 2018 19:14:34 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> As far as I can tell tlb_flush does not need to be called
> this early. tlb_flush is eventually called after the CPU
> has been realized.
>
> This change paves the way to the introduction of tlb_init,
> which will be called from cpu_exec_realizefn.
>
> Cc: Guan Xuetao <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/unicore32/cpu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c
> index 68f978d80b..2b49d1ca40 100644
> --- a/target/unicore32/cpu.c
> +++ b/target/unicore32/cpu.c
> @@ -116,8 +116,6 @@ static void uc32_cpu_initfn(Object *obj)
> env->uncached_asr = ASR_MODE_PRIV;
> env->regs[31] = 0x03000000;
> #endif
> -
> - tlb_flush(cs);
> }
>
> static const VMStateDescription vmstate_uc32_cpu = {
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
[Qemu-devel] [PATCH v5 6/6] cputlb: read CPUTLBEntry.addr_write atomically, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 2/6] target/unicore32: remove tlb_flush from uc32_init_fn, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 5/6] cputlb: serialize tlb updates with env->tlb_lock, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 3/6] exec: introduce tlb_init, Emilio G. Cota, 2018/10/09
[Qemu-devel] [PATCH v5 4/6] cputlb: fix assert_cpu_is_self macro, Emilio G. Cota, 2018/10/09
Re: [Qemu-devel] [PATCH v5 0/6] per-TLB lock, Richard Henderson, 2018/10/11