|
| From: | Stefan Berger |
| Subject: | Re: [Qemu-devel] [PATCH 26/31] tpm: Clean up error reporting in tpm_init_tpmdev() |
| Date: | Wed, 10 Oct 2018 15:00:29 -0400 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/8/18 1:31 PM, Markus Armbruster wrote:
Calling error_report() in a function that takes an Error ** argument is suspicious. tpm_init_tpmdev() does that, and then fails without setting an error. Its caller main(), via tpm_init() and qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Stefan Berger <address@hidden> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
| [Prev in Thread] | Current Thread | [Next in Thread] |