[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] Acceptance Tests: change the handling of
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/7] Acceptance Tests: change the handling of tests for specific archs |
Date: |
Sat, 13 Oct 2018 13:08:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Hi Cleber,
On 10/10/18 1:26 AM, Cleber Rosa wrote:
> With the introduction of a variants file that can run the same
> tests on various architectures, it makes sense to make most tests
> to be reusable on those environments. The exception should be
> when a test is really testing a specific architecture feature.
>
> With the change proposed here, on a command line such as:
>
> $ avocado run \
> --json-variants-load=tests/acceptance/variants/arch.json \
> -- tests/acceptance/
>
> The boot_linux_console.py tests will appear as "CANCELED: Currently
> specific to the x86_64 arch", which is as a good thing when compared
> to being ignored by tags because:
>
> * The architecture specific parts can be addressed
> * It will be run on the matching architecture (as opposed to always
> being filtered out by the tags mechanism)
> * CANCELED tests do no influence negatively the overall job results,
> they're not considered an error or failure
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> tests/acceptance/boot_linux_console.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index 58032f971c..ba3ac036da 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -19,12 +19,13 @@ class BootLinuxConsole(Test):
> and the kernel command line is properly passed from QEMU to the kernel
>
> :avocado: enable
> - :avocado: tags=x86_64
Can we keep a such tag (in format 'arch:x86_64') ...
> """
>
> timeout = 60
>
> def test(self):
> + if self.arch != 'x86_64':
> + self.cancel('Currently specific to the x86_64 target arch')
... and have this check generic? (Eventually via a QemuTest(Test) parent
class).
> kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/'
> 'Everything/x86_64/os/images/pxeboot/vmlinuz')
> kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a'
>
- Re: [Qemu-devel] [PATCH v2 6/7] Acceptance Tests: add variants definition for architectures, (continued)