qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 08/21] accel/tcg/cputlb: convert remaining t


From: Alex Bennée
Subject: Re: [Qemu-devel] [RFC PATCH 08/21] accel/tcg/cputlb: convert remaining tlb_debug() to trace events
Date: Mon, 15 Oct 2018 19:17:47 +0100
User-agent: mu4e 1.1.0; emacs 26.1.50

Richard Henderson <address@hidden> writes:

> On 10/5/18 8:48 AM, Alex Bennée wrote:
>> To avoid overly long lines in trace events I've split the event into
>> tlb_set_page and tlb_set_page_attrs.
>
> I don't think this split is a good idea.  It allows data from different 
> threads
> to be interleaved.

Won't we soon have a lock serialising this?

It was mainly to shut-up checkpatch because the trace-events don't seem
to do multi-line.

--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]