Re: [Qemu-devel] [RFC PATCH 07/21] accel/tcg/cputlb: convert tlb_flush debugging into trace events

[Richard Henderson]

On 10/15/18 11:23 AM, Alex Bennée wrote:
> 
> Richard Henderson <address@hidden> writes:
> 
>> On 10/5/18 8:48 AM, Alex Bennée wrote:
>>> +    trace_tlb_flush_all_work(cpu->cpu_index);
>>>      tlb_flush_nocheck(cpu);
>>> +    trace_tlb_flush_work_complete(__LINE__, cpu->cpu_index);
>>
>> Why is __LINE__ an interesting argument to a trace function?
> 
> Yeah - I wanted a unique key for each flush but that wasn't an opaque
> char ptr to a __FUNC__. I guess I should just go ahead and have a type
> enum? Can such a thing be exported via trace-events easily though?

I don't think so, at the moment.  I dunno what's best really.


r~