[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 06/14] target/arm: Filter cycle counter based
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 |
|
Date: |
Mon, 15 Oct 2018 13:51:51 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> --- a/target/arm/machine.c
> +++ b/target/arm/machine.c
> @@ -584,7 +584,7 @@ static int cpu_pre_save(void *opaque)
> {
> ARMCPU *cpu = opaque;
>
> - pmccntr_op_start(&cpu->env);
> + pmu_op_start(&cpu->env);
Does it make sense to move this patch earlier so that these hooks are modified
once? No big deal if not.
> +static inline bool pmu_counter_enabled(CPUARMState *env, uint8_t counter)
Drop the inline. This function is pretty big; we should let the compiler
choose.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~