Re: [Qemu-devel] [PATCH 3/3] po/Makefile: Modern shell scripting (use $() insteadof ``)

[maozy]

On 10/17/18 5:54 PM, Thomas Huth wrote:
> On 2018-10-17 11:44, Mao Zhongyi wrote:
> > Various shell files contain a mix between obsolete ``
> > and modern $(); It would be nice to convert to using $()
> > everywhere.
> >
> > Cc: address@hidden
> > Cc: address@hidden
> > Cc: address@hidden
> > Cc: address@hidden
> >
> > Signed-off-by: Mao Zhongyi <address@hidden>
> > ---
> >   po/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/po/Makefile b/po/Makefile
> > index e47e262ee6..10605e8eb3 100644
> > --- a/po/Makefile
> > +++ b/po/Makefile
> > @@ -36,7 +36,7 @@ clean:
> >   
> >   install: $(OBJS)
> >         for obj in $(OBJS); do \
> > -           base=`basename $$obj .mo`; \
> > +           base=$(basename $$obj .mo); \
>
> You're changing a Makefile here, so you need to "escape" the "$" by
> doubling it:
>
>         base=$$(basename $$obj .mo); \

OK, I see your point.

Thanks,
Mao

>   Thomas