[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V2 10/26] qmp event: Add COLO_EXIT event to notify us
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V2 10/26] qmp event: Add COLO_EXIT event to notify users while exited COLO |
Date: |
Fri, 19 Oct 2018 11:22:09 +0800 |
From: zhanghailiang <address@hidden>
If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
migration/colo.c | 31 +++++++++++++++++++++++++++++++
qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 69 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index d3163b5..bd7390d 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -28,6 +28,7 @@
#include "net/colo-compare.h"
#include "net/colo.h"
#include "block/block.h"
+#include "qapi/qapi-events-migration.h"
static bool vmstate_loading;
static Notifier packets_compare_notifier;
@@ -514,6 +515,23 @@ out:
qemu_fclose(fb);
}
+ /*
+ * There are only two reasons we can get here, some error happened
+ * or the user triggered failover.
+ */
+ switch (failover_get_state()) {
+ case FAILOVER_STATUS_NONE:
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_ERROR);
+ break;
+ case FAILOVER_STATUS_REQUIRE:
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_REQUEST);
+ break;
+ default:
+ abort();
+ }
+
/* Hope this not to be too long to wait here */
qemu_sem_wait(&s->colo_exit_sem);
qemu_sem_destroy(&s->colo_exit_sem);
@@ -746,6 +764,19 @@ out:
error_report_err(local_err);
}
+ switch (failover_get_state()) {
+ case FAILOVER_STATUS_NONE:
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_ERROR);
+ break;
+ case FAILOVER_STATUS_REQUIRE:
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_REQUEST);
+ break;
+ default:
+ abort();
+ }
+
if (fb) {
qemu_fclose(fb);
}
diff --git a/qapi/migration.json b/qapi/migration.json
index 6e8c212..4a18209 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -957,6 +957,44 @@
'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
##
+# @COLO_EXIT:
+#
+# Emitted when VM finishes COLO mode due to some errors happening or
+# at the request of users.
+#
+# @mode: report COLO mode when COLO exited.
+#
+# @reason: describes the reason for the COLO exit.
+#
+# Since: 3.1
+#
+# Example:
+#
+# <- { "timestamp": {"seconds": 2032141960, "microseconds": 417172},
+# "event": "COLO_EXIT", "data": {"mode": "primary", "reason": "request" }
}
+#
+##
+{ 'event': 'COLO_EXIT',
+ 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
+
+##
+# @COLOExitReason:
+#
+# The reason for a COLO exit
+#
+# @none: no failover has ever happened. This can't occur in the
+# COLO_EXIT event, only in the result of query-colo-status.
+#
+# @request: COLO exit is due to an external request
+#
+# @error: COLO exit is due to an internal error
+#
+# Since: 3.1
+##
+{ 'enum': 'COLOExitReason',
+ 'data': [ 'none', 'request', 'error' ] }
+
+##
# @x-colo-lost-heartbeat:
#
# Tell qemu that heartbeat is lost, request it to do takeover procedures.
--
2.5.0
- [Qemu-devel] [PULL V2 00/26] Net patches, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 01/26] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 02/26] colo-compare: implement the process of checkpoint, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 04/26] COLO: integrate colo compare with colo frame, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 03/26] colo-compare: use notifier to notify packets comparing result, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 05/26] COLO: Add block replication into colo process, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 07/26] COLO: Load dirty pages into SVM's RAM cache firstly, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 06/26] COLO: Remove colo_state migration struct, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 08/26] ram/COLO: Record the dirty pages that SVM received, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 09/26] COLO: Flush memory data from ram cache, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 10/26] qmp event: Add COLO_EXIT event to notify users while exited COLO,
Jason Wang <=
- [Qemu-devel] [PULL V2 11/26] qapi/migration.json: Rename COLO unknown mode to none mode., Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 12/26] qapi: Add new command to query colo status, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 14/26] COLO: flush host dirty ram from cache, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 13/26] savevm: split the process of different stages for loadvm/savevm, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 15/26] filter: Add handle_event method for NetFilterClass, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 17/26] COLO: notify net filters about checkpoint/failover event, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 19/26] docs: Add COLO status diagram to COLO-FT.txt, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 20/26] clean up callback when del virtqueue, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 18/26] COLO: quick failover process by kick COLO thread, Jason Wang, 2018/10/18