[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/6] tests/acceptance: Rename the generic Boo
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/6] tests/acceptance: Rename the generic BootLinuxConsole test as test_x86_64_pc |
Date: |
Fri, 19 Oct 2018 14:15:35 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/13/18 11:15 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acceptance/boot_linux_console.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index ba3ac036da..3aa4dbe5f9 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -15,7 +15,7 @@ from avocado_qemu import Test
>
> class BootLinuxConsole(Test):
> """
> - Boots a x86_64 Linux kernel and checks that the console is operational
> + Boots a Linux kernel and checks that the console is operational
> and the kernel command line is properly passed from QEMU to the kernel
>
> :avocado: enable
> @@ -23,7 +23,7 @@ class BootLinuxConsole(Test):
>
> timeout = 60
>
> - def test(self):
> + def test_x86_64_pc(self):
> if self.arch != 'x86_64':
> self.cancel('Currently specific to the x86_64 target arch')
> kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/'
>
This looks right, but given "self.arch" is still not on master, so I'm
holding on to giving the reviewed-by/tested-by.
Question: do you believe a maintainer and/or developer would want to
test specific machine types?
[Qemu-devel] [PATCH v3 5/6] tests/acceptance: Add test_sh4_r2d in BootLinuxConsole, Philippe Mathieu-Daudé, 2018/10/13
[Qemu-devel] [RFC PATCH v3 6/6] tests/acceptance: Add test_sh4_r2d in BootLinuxTracing, Philippe Mathieu-Daudé, 2018/10/13