qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option l


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option length
Date: Sun, 21 Oct 2018 21:22:45 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Hello,

Fam Zheng, le ven. 14 sept. 2018 15:26:15 +0800, a ecrit:
> When user provides a long domainname or hostname that doesn't fit in the
> DHCP packet, we mustn't overflow the response packet buffer. Instead,
> report errors, following the g_warning() in the slirp->vdnssearch
> branch.
> 
> Also check the strlen against 256 when initializing slirp, which limit
> is also from the protocol where one byte represents the string length.
> This gives an early error before the warning which is harder to notice
> or diagnose.

Applied to my tree, thanks!

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]