Re: [Qemu-devel] [PATCH 01/11] target/mips: Rename ASE_MMI to ASE_TOSHIBA_MMI, with Toshiba namespace

[Aleksandar Markovic]

> From: Fredrik Noring <address@hidden>
> Subject: [PATCH 01/11] target/mips: Rename ASE_MMI to ASE_TOSHIBA_MMI, with 
> Toshiba namespace
> 
> Several vendors have multimedia instruction (MMI) sets and other
> extensions of various kinds. ASE vendor namespaces make it clear these
> are not generic architectural features and also avoid name clashes.

ASE_XXX flags are not meant to identify a CPU or vendor. They are not wired to 
any configuration bit or CPU model. They are purely QEMU internal constructs, 
whose purpose was to make internal QEMU MIPS-specific code organization easier. 
In this case, ASE_MMI is an umbrella for all MMI-like ASEs, introduced with 
intent to make encapsulation of MMI-specific code better and easier. 
Differences between CPUs should be resolved by other means. Name 'ASE_MMI' is 
fine.

Thanks,
Aleksandar