Re: [Qemu-devel] [PATCH] target/mips: Add two missing breaks for NM_LLWPE and NM_SCWPE decoder cases

[Stefan Markovic]

On 29.10.18. 12:15, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Coverity found two fallthroughs that lack break statements. Fix them.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>   target/mips/translate.c | 2 ++
>   1 file changed, 2 insertions(+)


Reviewed-by: Stefan Markovic <address@hidden>


> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index b8ace0b..813ad19 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -21402,6 +21402,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState 
> *env, DisasContext *ctx)
>                           check_eva(ctx);
>                           check_cp0_enabled(ctx);
>                           gen_llwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 
> 5));
> +                        break;
>                       default:
>                           generate_exception_end(ctx, EXCP_RI);
>                           break;
> @@ -21420,6 +21421,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState 
> *env, DisasContext *ctx)
>                           check_eva(ctx);
>                           check_cp0_enabled(ctx);
>                           gen_scwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 
> 5));
> +                        break;
>                       default:
>                           generate_exception_end(ctx, EXCP_RI);
>                           break;