[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/6] monitor: inline ambiguous helper functions
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v2 1/6] monitor: inline ambiguous helper functions |
Date: |
Mon, 29 Oct 2018 16:57:28 +0400 |
The function were not named with "mon_iothread", or following the AIO
vs GMainContext distinction. Inline them instead.
Signed-off-by: Marc-André Lureau <address@hidden>
---
monitor.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/monitor.c b/monitor.c
index 823b5a1099..07712d89f9 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4448,16 +4448,6 @@ static void sortcmdlist(void)
qsort((void *)info_cmds, array_num, elem_size, compare_mon_cmd);
}
-static GMainContext *monitor_get_io_context(void)
-{
- return iothread_get_g_main_context(mon_iothread);
-}
-
-static AioContext *monitor_get_aio_context(void)
-{
- return iothread_get_aio_context(mon_iothread);
-}
-
static void monitor_iothread_init(void)
{
mon_iothread = iothread_create("mon_iothread", &error_abort);
@@ -4545,7 +4535,7 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)
GMainContext *context;
assert(mon->use_io_thread);
- context = monitor_get_io_context();
+ context = iothread_get_g_main_context(mon_iothread);
assert(context);
qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, monitor_qmp_read,
monitor_qmp_event, NULL, mon, context, true);
@@ -4597,7 +4587,7 @@ void monitor_init(Chardev *chr, int flags)
* since chardev might be running in the monitor I/O
* thread. Schedule a bottom half.
*/
- aio_bh_schedule_oneshot(monitor_get_aio_context(),
+ aio_bh_schedule_oneshot(iothread_get_aio_context(mon_iothread),
monitor_qmp_setup_handlers_bh, mon);
/* The bottom half will add @mon to @mon_list */
return;
--
2.19.0.271.gfe8321ec05
- [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes, Marc-André Lureau, 2018/10/29
- [Qemu-devel] [PATCH v2 1/6] monitor: inline ambiguous helper functions,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v2 2/6] monitor: accept chardev input from iothread, Marc-André Lureau, 2018/10/29
- [Qemu-devel] [PATCH v2 3/6] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag, Marc-André Lureau, 2018/10/29
- [Qemu-devel] [PATCH v2 4/6] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/10/29
- [Qemu-devel] [PATCH v2 6/6] monitor: avoid potential dead-lock when cleaning up, Marc-André Lureau, 2018/10/29
- [Qemu-devel] [PATCH v2 5/6] monitor: prevent inserting new monitors after cleanup, Marc-André Lureau, 2018/10/29
- Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes, Peter Xu, 2018/10/30