[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] microbit: do not rely on -kernel option
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] microbit: do not rely on -kernel option |
|
Date: |
Mon, 29 Oct 2018 20:15:39 +0000 |
On Mon, Oct 29, 2018 at 7:46 PM Stefan Hajnoczi <address@hidden> wrote:
> @@ -39,8 +47,12 @@ static void microbit_init(MachineState *machine)
> &error_fatal);
> object_property_set_bool(soc, true, "realized", &error_fatal);
>
> - armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,
> - NRF51_SOC(soc)->flash_size);
> + if (machine->kernel_filename) {
> + error_report("-device loader,file=<filename> must be used instead of
> -kernel");
> + exit(1);
> + }
NACK
Julia pointed out this breaks boot-serial-test.
Stefan