[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secon
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary |
Date: |
Tue, 30 Oct 2018 16:42:55 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* Eric Blake (address@hidden) wrote:
> [adding qemu-trivial]
>
> On 03/20/2017 07:27 PM, wangguang wrote:
> > Subject: [PATCH] Fix Colo doc secondeary should be secondary
>
> This line feels redundant compared to the overall mail's subject line.
> In turn, that subject could use a space after colon.
>
> > This is an error in COLO-FT.txt.
> > secondeary-disk0 should be secondary-disk0.
> >
> > Signed-off-by: Guang Wang <address@hidden>
> > ---
> > docs/COLO-FT.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> As it is doc-only, it is safe for hard freeze, but also not the end of
> the world if it doesn't go in until 2.10.
Manually applied and queued for migration
(ahem a little late)
Dave
> >
> > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
> > index e289be2..bec7547 100644
> > --- a/docs/COLO-FT.txt
> > +++ b/docs/COLO-FT.txt
> > @@ -139,7 +139,7 @@ Secondary:
> > { 'execute': 'nbd-server-start',
> > 'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
> > 'port': '8889'} } }
> > }
> > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
> > 'writable': true } }
> > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
> > 'writable': true } }
> >
> > Note:
> > a. The qmp command nbd-server-start and nbd-server-add must be run
> >
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary,
Dr. David Alan Gilbert <=