[Qemu-devel] [PULL 5/5] target/mips: Enable only tested modes for R5900

[Aleksandar Markovic]

From: Aleksandar Markovic <address@hidden>

Enable MIPS 032 user mode for R5900.

Expose to end-user only features that make sense and are appropriately
tested. In this case, enable only MIPS 032 user mode for R5900.

About defined(CONFIG_USER_ONLY), it is just because a reasonable
testing was not provided for system mode. Some reasonable
("acceptance") testing should be done, and made available
to others. A system image, kernel, and command line + plus
some relatively mild testing of system mode should suffice.

About !defined(TARGET_MIPS64), this is because O32 is the only
supported user-mode ABI for this CPU.

Reviewed-by: Stefan Markovic <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
---
 target/mips/translate_init.inc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.inc.c
index cab2003..d84c58e 100644
--- a/target/mips/translate_init.inc.c
+++ b/target/mips/translate_init.inc.c
@@ -410,6 +410,8 @@ const mips_def_t mips_defs[] =
         .insn_flags = CPU_MIPS32R5 | ASE_MSA,
         .mmu_type = MMU_TYPE_R4000,
     },
+#if defined(CONFIG_USER_ONLY)
+#if !defined(TARGET_MIPS64)
     {
         .name = "R5900",
         .CP0_PRid = 0x00002E00,
@@ -457,6 +459,8 @@ const mips_def_t mips_defs[] =
         .insn_flags = CPU_R5900 | ASE_MMI,
         .mmu_type = MMU_TYPE_R4000,
     },
+#endif
+#endif
     {
         /* A generic CPU supporting MIPS32 Release 6 ISA.
            FIXME: Support IEEE 754-2008 FP.
-- 
2.7.4