[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] target/mips: Enable only tested modes fo
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 5/5] target/mips: Enable only tested modes for R5900 |
|
Date: |
Tue, 30 Oct 2018 17:30:40 +0000 |
> Do you mind adding those one line comment when applying this series?
>
> > +#if defined(CONFIG_USER_ONLY)
>
> #if defined(CONFIG_USER_ONLY) /* System mode not implemented */
>
> > +#if !defined(TARGET_MIPS64)
>
> #if !defined(TARGET_MIPS64) /* Only O32 user-mode ABI is supported */
I do think this is a very good idea, but it was too late - I was already well
into preparing pull request when I read this.
Thanks,
Aleksandar
- [Qemu-devel] [PATCH v3 0/5] target/mips: Renaming and limiting modes for R5900, Aleksandar Markovic, 2018/10/30
- [Qemu-devel] [PATCH v3 4/5] target/mips: Misc R5900-related cosmetic changes, Aleksandar Markovic, 2018/10/30
- [Qemu-devel] [PATCH v3 3/5] target/mips: Rename MMI-related functions, Aleksandar Markovic, 2018/10/30
- [Qemu-devel] [PATCH v3 1/5] target/mips: Rename MMI-related masks, Aleksandar Markovic, 2018/10/30
- [Qemu-devel] [PATCH v3 2/5] target/mips: Rename MMI-related opcodes, Aleksandar Markovic, 2018/10/30
- [Qemu-devel] [PATCH v3 5/5] target/mips: Enable only tested modes for R5900, Aleksandar Markovic, 2018/10/30