[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/10] target/i386: Clear RF on SYSCALL instruction
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 05/10] target/i386: Clear RF on SYSCALL instruction |
Date: |
Tue, 30 Oct 2018 20:50:06 +0100 |
From: Rudolf Marek <address@hidden>
Fix the SYSCALL instruction in 64-bit (long mode). The RF flag
should be cleared in R11 as well as in the RFLAGS. Intel
and AMD CPUs behave same. AMD has this documented in the
APM vol 3.
Signed-off-by: Roman Kapl <address@hidden>
Signed-off-by: Rudolf Marek <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
target/i386/seg_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c
index 33714bc..63e265c 100644
--- a/target/i386/seg_helper.c
+++ b/target/i386/seg_helper.c
@@ -991,11 +991,11 @@ void helper_syscall(CPUX86State *env, int next_eip_addend)
int code64;
env->regs[R_ECX] = env->eip + next_eip_addend;
- env->regs[11] = cpu_compute_eflags(env);
+ env->regs[11] = cpu_compute_eflags(env) & ~RF_MASK;
code64 = env->hflags & HF_CS64_MASK;
- env->eflags &= ~env->fmask;
+ env->eflags &= ~(env->fmask | RF_MASK);
cpu_load_eflags(env, env->eflags, 0);
cpu_x86_load_seg_cache(env, R_CS, selector & 0xfffc,
0, 0xffffffff,
--
1.8.3.1
- [Qemu-devel] [PULL 00/10] Misc patches for 2018-10-30, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 08/10] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 05/10] target/i386: Clear RF on SYSCALL instruction,
Paolo Bonzini <=
- [Qemu-devel] [PULL 04/10] MAINTAINERS: remove or downgrade myself to reviewer from some subsystems, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 02/10] x86: hv_evmcs CPU flag support, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 01/10] icount: fix deadlock when all cpus are sleeping, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 10/10] lsi53c895a: check message length value is valid, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 07/10] nvdimm: set non-volatile on the memory region, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 03/10] i386: clarify that the Q35 machine type implements a P35 chipset, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 06/10] memory: learn about non-volatile memory region, Paolo Bonzini, 2018/10/30
- [Qemu-devel] [PULL 09/10] scripts/dump-guest-memory: Synchronize with guest_phys_blocks_region_add, Paolo Bonzini, 2018/10/30