[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/7] target/i386: Remove #ifdeffed-out icebp debuggin
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 2/7] target/i386: Remove #ifdeffed-out icebp debugging hack |
Date: |
Tue, 30 Oct 2018 21:45:45 -0300 |
From: Peter Maydell <address@hidden>
Remove a debugging hack which could be used to cause the
undocumented 'icebp' instruction to enable QEMU internal
debug logging. This code has always been #ifdeffed out
since it was introduced in commit aba9d61e34b9 in 2005;
judging by the rest of that commit (which is entirely
unrelated) it may have even been committed by accident.
(Note that WANT_ICEBP is not defined by default anyway.)
Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
target/i386/translate.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 83c1ebe491..f8bc7680af 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -7028,13 +7028,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState
*cpu)
#ifdef WANT_ICEBP
case 0xf1: /* icebp (undocumented, exits to external debugger) */
gen_svm_check_intercept(s, pc_start, SVM_EXIT_ICEBP);
-#if 1
gen_debug(s, pc_start - s->cs_base);
-#else
- /* start debug */
- tb_flush(CPU(x86_env_get_cpu(env)));
- qemu_set_log(CPU_LOG_INT | CPU_LOG_TB_IN_ASM);
-#endif
break;
#endif
case 0xfa: /* cli */
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [PULL 0/7] x86 queue, 2018-10-30, Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 1/7] i386: correct cpu_x86_cpuid(0xd), Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 5/7] x86: define a new MSR based feature word -- FEATURE_WORDS_ARCH_CAPABILITIES, Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 7/7] i386: Add PKU on Skylake-Server CPU model, Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 2/7] target/i386: Remove #ifdeffed-out icebp debugging hack,
Eduardo Habkost <=
- [Qemu-devel] [PULL 3/7] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 6/7] i386: Add new model of Cascadelake-Server, Eduardo Habkost, 2018/10/30
- [Qemu-devel] [PULL 4/7] x86: Data structure changes to support MSR based features, Eduardo Habkost, 2018/10/30
- Re: [Qemu-devel] [PULL 0/7] x86 queue, 2018-10-30, Eduardo Habkost, 2018/10/31