Re: [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v3 00/24] qemu-ga patch queue for soft-freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2945648248 qga-win: changing --retry-path option behavior
1dd5ffbaf2 qga-win: report specific error when failing to open channel
a70912bd9d qga-win: install service with --retry-path set by default
a30014b809 qga: add --retry-path option for re-initializing channel on failure
fdb7b79544 qga: move w32 service handling out of run_agent()
a9609a5607 qga: hang GAConfig/socket_activation off of GAState global
854283c81c qga: group agent init/cleanup init separate routines
0b487b0980 qga: fix an off-by-one issue
72962f5f96 qga-win: demystify namespace stripping
10b860cc42 qga-win: return disk device in guest-get-fsinfo
c76f3ae35c qga-win: handle multi-disk volumes
2ae03f49d7 qga-win: refactor disk info
b5d02ef13d qga-win: report disk serial number
a4bd640311 qga-win: refactor disk properties (bus)
1cdeca5df5 qga-win: add debugging information
ea9fecfb1e build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI
20e22cfb4f qga-win: fsinfo: pci-info: allow partial info
7b5f1dbb20 qga-win: prevent crash when executing fsinfo command
0cefae5e5d qga: linux: return disk device in guest-get-fsinfo
4f1272f253 qga: linux: report disk serial number
57296b86fe configure: add test for libudev
9510c4fc7c qga: ignore non present cpus when handling qmp_guest_get_vcpus()
13136d1624 qga-win: add support for qmp_guest_fsfreeze_freeze_list
bb7be0683a qga: Support Unicode paths in guest-file-open on win32

=== OUTPUT BEGIN ===
Checking PATCH 1/24: qga: Support Unicode paths in guest-file-open on win32...
Checking PATCH 2/24: qga-win: add support for qmp_guest_fsfreeze_freeze_list...
Checking PATCH 3/24: qga: ignore non present cpus when handling 
qmp_guest_get_vcpus()...
Checking PATCH 4/24: configure: add test for libudev...
Checking PATCH 5/24: qga: linux: report disk serial number...
Checking PATCH 6/24: qga: linux: return disk device in guest-get-fsinfo...
Checking PATCH 7/24: qga-win: prevent crash when executing fsinfo command...
Checking PATCH 8/24: qga-win: fsinfo: pci-info: allow partial info...
Checking PATCH 9/24: build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI...
Checking PATCH 10/24: qga-win: add debugging information...
Checking PATCH 11/24: qga-win: refactor disk properties (bus)...
Checking PATCH 12/24: qga-win: report disk serial number...
WARNING: line over 80 characters
#39: FILE: qga/commands-win32.c:652:
+            error_setg(errp, "failed to get serial number: offset outside the 
buffer");

total: 0 errors, 1 warnings, 36 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 13/24: qga-win: refactor disk info...
Checking PATCH 14/24: qga-win: handle multi-disk volumes...
ERROR: "foo*bar" should be "foo *bar"
#148: FILE: qga/commands-win32.c:786:
+                + extents->NumberOfDiskExtents*sizeof(DISK_EXTENT);

total: 1 errors, 0 warnings, 185 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/24: qga-win: return disk device in guest-get-fsinfo...
Checking PATCH 16/24: qga-win: demystify namespace stripping...
Checking PATCH 17/24: qga: fix an off-by-one issue...
Checking PATCH 18/24: qga: group agent init/cleanup init separate routines...
Checking PATCH 19/24: qga: hang GAConfig/socket_activation off of GAState 
global...
Checking PATCH 20/24: qga: move w32 service handling out of run_agent()...
Checking PATCH 21/24: qga: add --retry-path option for re-initializing channel 
on failure...
Checking PATCH 22/24: qga-win: install service with --retry-path set by 
default...
Checking PATCH 23/24: qga-win: report specific error when failing to open 
channel...
Checking PATCH 24/24: qga-win: changing --retry-path option behavior...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden