[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/3] nbd-client: drop extra error noise
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH 0/3] nbd-client: drop extra error noise |
Date: |
Fri, 2 Nov 2018 18:11:49 +0300 |
Hi all.
It was discussed, that error messages, produced by error_reprt_err's,
added in f140e300 are
1. not really needed
2. subject to race conditions
And it was decided to drop them (switch to trace-points), look thread
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00833.html
So, I've also dropped error_report_err, added earlier in be41c100c0d
and later in 78a33ab5878.
Hmm, I've tried to run 83 iotest in a loop, and it didn't fail, even
before these patches.
Vladimir Sementsov-Ogievskiy (3):
error: add error_get_hint
nbd: publish _lookup functions
block/nbd-client: use traces instead of noisy error_report_err
include/block/nbd.h | 5 +++++
include/qapi/error.h | 5 +++++
nbd/nbd-internal.h | 5 -----
block/nbd-client.c | 27 +++++++++++++++++++++++----
util/error.c | 5 +++++
block/trace-events | 4 ++++
tests/qemu-iotests/083.out | 28 ----------------------------
7 files changed, 42 insertions(+), 37 deletions(-)
--
2.18.0
- [Qemu-devel] [PATCH 0/3] nbd-client: drop extra error noise,
Vladimir Sementsov-Ogievskiy <=