Re: [Qemu-devel] [PATCH v3 8/8] docker: use HTTPS git URL for virglrenderer

[Philippe Mathieu-Daudé]

On 4/11/18 12:24, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks.  HTTPS is more secure
> since the client verifies the server certificate.
>
> Cc: Philippe Mathieu-Daudé <address@hidden>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   tests/docker/dockerfiles/debian-amd64.docker | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker 
> b/tests/docker/dockerfiles/debian-amd64.docker
> index eb13f06ed1..24b113b76f 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -24,7 +24,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
>           libegl1-mesa-dev \
>           libepoxy-dev \
>           libgbm-dev
> -RUN git clone git://anongit.freedesktop.org/virglrenderer 
> /usr/src/virglrenderer
> +RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git 
> /usr/src/virglrenderer
>   RUN cd /usr/src/virglrenderer && ./autogen.sh && ./configure --with-glx 
> --disable-tests && make install
>   
>   # netmap