[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 07/13] tests: Add bbc:microbit / nRF51 test s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 07/13] tests: Add bbc:microbit / nRF51 test suite |
Date: |
Mon, 5 Nov 2018 16:51:04 +0000 |
On 2 November 2018 at 17:07, Steffen Görtz <address@hidden> wrote:
> The microbit-test includes tests for the nRF51 NVMC
> peripheral and will host future nRF51 peripheral tests
> and board-level bbc:microbit tests.
>
> Signed-off-by: Steffen Görtz <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/Makefile.include | 2 +
> tests/microbit-test.c | 117 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 119 insertions(+)
> create mode 100644 tests/microbit-test.c
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f77a495109..602346eeed 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -274,6 +274,7 @@ check-qtest-sparc64-y += tests/boot-serial-test$(EXESUF)
> check-qtest-arm-y += tests/tmp105-test$(EXESUF)
> check-qtest-arm-y += tests/pca9552-test$(EXESUF)
> check-qtest-arm-y += tests/ds1338-test$(EXESUF)
> +check-qtest-arm-y += tests/microbit-test$(EXESUF)
> check-qtest-arm-y += tests/m25p80-test$(EXESUF)
> check-qtest-arm-y += tests/virtio-blk-test$(EXESUF)
> check-qtest-arm-y += tests/test-arm-mptimer$(EXESUF)
> @@ -695,6 +696,7 @@ tests/pxe-test$(EXESUF): tests/pxe-test.o
> tests/boot-sector.o $(libqos-obj-y)
> tests/tmp105-test$(EXESUF): tests/tmp105-test.o $(libqos-omap-obj-y)
> tests/pca9552-test$(EXESUF): tests/pca9552-test.o $(libqos-omap-obj-y)
> tests/ds1338-test$(EXESUF): tests/ds1338-test.o $(libqos-imx-obj-y)
> +tests/microbit-test$(EXESUF): tests/microbit-test.o
> tests/m25p80-test$(EXESUF): tests/m25p80-test.o
> tests/i440fx-test$(EXESUF): tests/i440fx-test.o $(libqos-pc-obj-y)
> tests/q35-test$(EXESUF): tests/q35-test.o $(libqos-pc-obj-y)
> diff --git a/tests/microbit-test.c b/tests/microbit-test.c
> new file mode 100644
> index 0000000000..743f831466
> --- /dev/null
> +++ b/tests/microbit-test.c
> @@ -0,0 +1,117 @@
> + /*
> + * QTest testcase for Microbit board using the Nordic Semiconductor nRF51
> SoC.
> + *
> + * nRF51:
> + * Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf
> + * Product Spec: http://infocenter.nordicsemi.com/pdf/nRF51822_PS_v3.1.pdf
> + *
> + * Microbit Board: http://microbit.org/
> + *
> + * Copyright 2018 Steffen Görtz <address@hidden>
> + *
> + * This code is licensed under the GPL version 2 or later. See
> + * the COPYING file in the top-level directory.
> + */
> +
> +
> +#include "qemu/osdep.h"
> +#include "exec/hwaddr.h"
> +#include "libqtest.h"
> +
> +#include "hw/arm/nrf51.h"
> +#include "hw/nvram/nrf51_nvm.h"
> +
> +#define FLASH_SIZE (256 * NRF51_PAGE_SIZE)
> +
> +static void fill_and_erase(hwaddr base, hwaddr size, uint32_t address_reg)
> +{
> + /* Fill memory */
> + writel(NRF51_NVMC_BASE + NRF51_NVMC_CONFIG, 0x01);
> + for (hwaddr i = 0; i < size; i++) {
Looks like you missed this "declaration inside for()".
> + writeb(base + i, i);
> + g_assert_cmpuint(readb(base + i), ==, i & 0xFF);
> + }
thanks
-- PMM
- [Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 03/13] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 01/13] qtest: Add set_irq_in command to set IRQ/GPIO level, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 07/13] tests: Add bbc:microbit / nRF51 test suite, Steffen Görtz, 2018/11/02
- Re: [Qemu-devel] [PATCH v4 07/13] tests: Add bbc:microbit / nRF51 test suite,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 02/13] arm: Add header to host common definition for nRF51 SOC peripherals, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 04/13] arm: Instantiate NRF51 random number generator, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 13/13] arm: Add Clock peripheral stub to NRF51 SOC, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 10/13] tests/microbit-test: Add Tests for nRF51 GPIO, Steffen Görtz, 2018/11/02
- [Qemu-devel] [PATCH v4 06/13] arm: Instantiate NRF51 special NVM's and NVMC, Steffen Görtz, 2018/11/02