qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in C


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qapi: misc: change the 'pc' to unsinged 64 in CpuInfo
Date: Mon, 5 Nov 2018 17:01:50 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 11/2/18 6:01 AM, Li Qiang wrote:
When trigger a 'query-cpus' qmp, the pc is an signed value like
following:
{"arch": "x86", ...  "pc": -1732653994, "halted": true,...}
It is strange. Change it to uint64_t.

Signed-off-by: Li Qiang <address@hidden>
---
  qapi/misc.json | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

I don't see this as causing any major backwards-incompatible behavior to clients that can parse full 64-bit unsigned numbers (note that not all JSON parsers do so - here's frowning at you, jansson - but libvirt is okay).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]