Re: [Qemu-devel] [PATCH 2/2] tpm: use loop iterator to set sts data field

[Marc-André Lureau]

Hi

On Tue, Nov 6, 2018 at 9:24 AM P J P <address@hidden> wrote:
>
> From: Prasad J Pandit <address@hidden>
>
> When TIS request is done, set 'sts' data field across all localities.

The code certainly meant to set the field across all localities.
However I don't see in the "TCG PC Client Specific TPM Interface
Specification (TIS)" where it states that the field should be set
across all localities. Could you quote the relevant part?

thanks

> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
>  hw/tpm/tpm_tis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index 20126dd838..58d90645bc 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -299,7 +299,7 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)
>
>      if (s->cmd.selftest_done) {
>          for (l = 0; l < TPM_TIS_NUM_LOCALITIES; l++) {
> -            s->loc[locty].sts |= TPM_TIS_STS_SELFTEST_DONE;
> +            s->loc[l].sts |= TPM_TIS_STS_SELFTEST_DONE;
>          }
>      }
>
> --
> 2.17.2
>
>


-- 
Marc-André Lureau