Re: [Qemu-devel] List of files containing devices which have not been QOMified

[Philippe Mathieu-Daudé]

On 6/11/18 19:43, Peter Maydell wrote:
> I had an idea for how to get a rough list of source files
> containing devices that haven't been QOMified. The theory
> is that a pre-QOM device generally has an "init" function
> which allocates memory for the device struct. So looking in
> hw/ for files which call g_new*() or g_malloc*() should get
> us all the non-QOM devices (as well as a pile of false
> positives, of course). The following link is the result of
> doing that and then eyeballing the results for false positives
> and throwing those out. It might have missed one or two
> files or included one or two by mistake. But I think it's
> pretty close, and it seems to have caught all the obvious
> ones I knew about. There are 61 files on this list.
>
> I am also suspicious about hw/bt/ but don't know enough
> about that subsystem to say if it could benefit from
> using QOM objects more.

> hw/arm/exynos4210.c
I already did this one.

> hw/sd/omap_mmc.c
I will do this one.

> hw/mips/mips_malta.c
> hw/timer/mips_gictimer.c
I'm interested in doing those two.

> hw/char/parallel.c
> hw/char/serial.c
> hw/display/vga-isa-mm.c
> hw/input/pckbd.c
> hw/input/ps2.c
I can do those too when QOM'ifying the Malta.

> hw/char/sh_serial.c
> hw/sh4/r2d.c
> hw/sh4/sh7750.c
> hw/timer/sh_timer.c
If nobody volonteers, I can take those.

Regards,

Phil.