[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function
From: |
Lukáš Hrázký |
Subject: |
Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest |
Date: |
Thu, 08 Nov 2018 11:05:10 +0100 |
Hello,
On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > + * The device_display_id_{start,count} denotes the sequence of device
> > display
> > + * IDs that map to the zero-based sequence of monitor IDs provided by
> > monitors
> > + * config on this interface. For example with device_display_id_start = 2
> > and
> > + * device_display_id_count = 3 you get the following mapping:
> > + * monitor_id -> device_display_id
> > + * 0 -> 2
> > + * 1 -> 3
> > + * 2 -> 4
> > + *
> > + * Note this example is unsupported in practice. The only supported cases
> > are
> > + * either a single device display ID (count = 1) or multiple device
> > display IDs
> > + * in a sequence starting from 0.
>
> This is confusing. The usage of this api in the qemu counterpart looks
> sane though.
Not sure what you find confusing in particular... The example? Using an
example and then saying it's not supported? (I wated to use a
nontrivial example that will show the concept...) Suggestions for
improvement?
Thanks,
Lukas
> cheers,
> Gerd
>
[Qemu-devel] [RFC PATCH qemu v3 3/3] spice: set device address and device display ID in QXL interface, Lukáš Hrázký, 2018/11/07