[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI de
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created |
Date: |
Thu, 8 Nov 2018 12:14:46 +0100 |
On Mon, 5 Nov 2018 13:46:10 +0100
David Hildenbrand <address@hidden> wrote:
> On 05.11.18 13:41, Cornelia Huck wrote:
> > On Mon, 5 Nov 2018 13:04:04 +0100
> > Thomas Huth <address@hidden> wrote:
> >
> >> On 2018-11-05 12:03, David Hildenbrand wrote:
> >>> Right now, errors during realize()/pre_plug/plug of the zPCI device
> >>> would result in QEMU crashing instead of failing nicely when creating
> >>> a zPCI device for a PCI device.
> >
> > Yeah, failing instead of crashing is better :)
> >
> > Is there any way we can trigger this problem for testing?
>
> I guess trying to add more PCI devices (with implicit zPCI devices
> getting created) than we have zPCI slots should be enough. So making
> e.g. s390_pci_alloc_idx() fail.
>
> (FH_MASK_INDEX = 0x0000ffff implies 65536 devices, which is not really
> easy to test ;) )
>
I was hoping for an easy test. Oh well :)
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, (continued)
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, David Hildenbrand, 2018/11/05
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, Christian Borntraeger, 2018/11/05
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, David Hildenbrand, 2018/11/05
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, Collin Walling, 2018/11/07
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, Cornelia Huck, 2018/11/08
- Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge, David Hildenbrand, 2018/11/08
[Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created, David Hildenbrand, 2018/11/05
Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created, Collin Walling, 2018/11/07
Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created, Cornelia Huck, 2018/11/08
Re: [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups, Cornelia Huck, 2018/11/12