Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Philippe Mathieu-Daudé]

On 8/11/18 13:52, Peter Maydell wrote:
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   qga/guest-agent-core.h | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
>    * This work is licensed under the terms of the GNU GPL, version 2 or later.
>    * See the COPYING file in the top-level directory.
>    */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
>   #include "qapi/qmp/dispatch.h"
>   #include "qemu-common.h"
>   #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
>   #ifndef _WIN32
>   void reopen_fd_to_null(int fd);
>   #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */