Re: [Qemu-devel] [PATCH] edid: silence a stringop-overflow warning

[Gerd Hoffmann]

On Sat, Nov 10, 2018 at 03:16:23PM +0400, Marc-André Lureau wrote:
> Simplify the code that doesn't need strncpy() since length of string
> is already computed.
> 
> /home/elmarco/src/qemu/hw/display/edid-generate.c: In function 
> 'edid_desc_text':
> /home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy' 
> specified bound depends on the length of the source argument 
> [-Werror=stringop-overflow=]
>      strncpy((char *)(desc + 5), text, len);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/elmarco/src/qemu/hw/display/edid-generate.c:164:11: note: length 
> computed here
>      len = strlen(text);
>            ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Signed-off-by: Marc-André Lureau <address@hidden>

queued for 3.1

thanks,
  Gerd