Re: [Qemu-devel] [PATCH] linux-user: Remove dead error-checking code

[Peter Maydell]

On 12 November 2018 at 14:45, Laurent Vivier <address@hidden> wrote:
> On 12/11/2018 15:38, Peter Maydell wrote:
>> On 19 October 2018 at 17:26, Laurent Vivier <address@hidden> wrote:
>>> Le 19/10/2018 à 18:17, Peter Maydell a écrit :
>>>> Remove some dead code spotted by Coverity (CID 1009855,
>>>> 1390854, 1390847). The underlying cause in all these cases
>>>> is the same: QEMU's put_user operations can't result in
>>>> errors, but the kernel's equivalent does. So when code
>>>> was copied from the kernel signal-frame-setup/teardown
>>>> code, checks on error flags that were needed in the kernel
>>>> became dead code for us.
>>>>
>>>> Signed-off-by: Peter Maydell <address@hidden>
>>>> ---
>>>>  linux-user/m68k/signal.c  | 3 ---
>>>>  linux-user/sh4/signal.c   | 4 ----
>>>>  linux-user/sparc/signal.c | 2 --
>>>>  3 files changed, 9 deletions(-)
>>>>
>>>
>>> Reviewed-by: Laurent Vivier <address@hidden>
>>
>> Ping? Looks like you reviewed this but it hasn't made it into
>> a pullreq.
>
> Sorry... do you want it in 3.1?

I think it would be nice to, since it does silence some Coverity
issues.

thanks
-- PMM