qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 02/11] decodetree: Add multiple include guar


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [RFC PATCH 02/11] decodetree: Add multiple include guard
Date: Tue, 13 Nov 2018 00:30:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 12/11/18 23:30, Eduardo Habkost wrote:
On Mon, Nov 12, 2018 at 12:36:13AM +0100, Philippe Mathieu-Daudé wrote:
It is necessary when splitting an ISA, or when using multiple ISAs.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
TODO: explain why, use case
TODO: escape full path?
---
  scripts/decodetree.py | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 0bc73b5990..5dea15e7a5 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -1030,7 +1030,11 @@ def main():
      else:
          output_fd = sys.stdout
+ hdr_guard = filename.split(os.path.sep)[-1].upper().replace('.', '_') + "_H"

Isn't
   filename.split(os.path.sep)[-1]
equivalent to
   os.path.basename(filename)
?

Yes, thanks :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]