[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for vari
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards |
Date: |
Thu, 15 Nov 2018 09:55:21 +0000 |
On 15 November 2018 at 09:51, Alex Bennée <address@hidden> wrote:
>
> Alistair Francis <address@hidden> writes:
>
>> On 14/11/2018 3:12 am, Peter Maydell wrote:
>>> On 13 November 2018 at 20:10, Alistair Francis <address@hidden> wrote:
>>>> These two and the Xilinx boards seem a little out of place in this
>>>> patch. I agree they probably aren't maintained as well as they should
>>>> be, but the patch talks about orphaned boards and these four all have
>>>> active QEMU maintainers listed.
>>>
>>> Yeah, I was planning to improve the commit message,
>>> something along the lines of an extra para:
>>>
>>> "The Xilinx boards are maintained, but patches to
>>> them go via the target-arm tree, so add myself as a
>>> maintainer there too."
>>>
>>> Really this is because we're overloading "maintainer"
>>> to mean both "this person cares about and is the
>>> primary reviewer and yes/no decision for them" and
>>> also "this person is responsible for getting the
>>> patches into the tree". Perhaps we should instead
>>> define a new letter tag for the latter ?
>>
>> What about adding a "P:" tag for pull request sender?
>
> Don't all pull requests generally come from the relevant T: (tree)?
What relevant tree? There isn't a T: tag for the target-arm
tree (it would not be of much use to quote a git url for
it in MAINTAINERS because I don't expect people to base
work on top of it or indeed generally push it publicly
until I'm doing a pull request from it). Also, a git URL
is not an email that can be cc'd on a patch submission
or ping...
> could either extend that or just state the first M: in the list is the
> person who owns the relevant tree.
I think the first M: should be the actual maintainer of
the code, personally.
thanks
-- PMM
Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards, Peter Maydell, 2018/11/19