[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp inter
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals |
Date: |
Thu, 15 Nov 2018 14:19:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Only slirp/libslirp.h should be included.
>
> Instead of using some slirp declarations and utility functions directly,
> let's copy them in net/util.h.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> net/colo.h | 3 +--
> net/util.h | 55 +++++++++++++++++++++++++++++++++++++++++++
> net/colo-compare.c | 1 +
> net/colo.c | 1 +
> net/filter-rewriter.c | 1 +
> net/slirp.c | 2 +-
> stubs/slirp.c | 2 +-
> 7 files changed, 61 insertions(+), 4 deletions(-)
Can you merge net/util.h and net/eth.h?
Thanks,
Paolo
- [Qemu-devel] [PATCH for-3.2 36/41] slirp: remove dead TCP_ACK_HACK code, (continued)
- [Qemu-devel] [PATCH for-3.2 36/41] slirp: remove dead TCP_ACK_HACK code, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 37/41] slirp: replace ARRAY_SIZE with G_N_ELEMENTS, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 39/41] slirp: move QEMU state saving to a separate unit, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 41/41] build-sys: add a basic meson build, Marc-André Lureau, 2018/11/14
- [Qemu-devel] [PATCH for-3.2 40/41] slirp: replace remaining QEMU dependency, Marc-André Lureau, 2018/11/14
- Re: [Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project, Markus Armbruster, 2018/11/14